Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use swift 5.0 #36

Merged
merged 1 commit into from
Aug 18, 2019
Merged

Use swift 5.0 #36

merged 1 commit into from
Aug 18, 2019

Conversation

cozzin
Copy link
Contributor

@cozzin cozzin commented Aug 10, 2019

I want to make PR about changing completion block to Result type.
However, we need to update to swift5 to use the Result type.

@cozzin
Copy link
Contributor Author

cozzin commented Aug 10, 2019

@satoshi-takano CI server made an error.

"Maximum number of login attempts exceeded. Please try again later."

Carthage/Carthage#1236
I think it is related with GITHUB_ACCESS_TOKEN

@satoshi-takano
Copy link
Owner

@cozzin Thanks very much for your pull request!
I'll try to resolve the failure on the CI later.

@satoshi-takano satoshi-takano merged commit 6e5b739 into satoshi-takano:master Aug 18, 2019
@cozzin cozzin deleted the feature/swift5.0 branch August 19, 2019 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cozzin @satoshi-takano