Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CaseIterable to OpenGraphMetadata #32

Merged
merged 2 commits into from
Nov 1, 2018

Conversation

robbiet480
Copy link
Contributor

This adds the new in Swift 4.2 CaseIterable to the OpenGraphMetadata enum to allow iterating all possible cases of the enum. For those not on Swift 4.2 yet, there is a compatibility protocol I found on StackOverflow.

This allows me to iterate the entire OpenGraph dictionary by its keys without needing to make the dictionary public.

@satoshi-takano
Copy link
Owner

Hi @robbiet480 , Thanks for your pull request!
Could you please update osx_image field in .travis.yml to osx_image: xcode10 because the Travis CI build has failed. Other changes are great 👍 Thanks.

@robbiet480
Copy link
Contributor Author

@satoshi-takano Did that, looks like tests are now failing because "Maximum number of login attempts exceeded. Please try again later." while getting OHHTTPStubs.

@satoshi-takano
Copy link
Owner

@robbiet480 Thanks for fixing! In fact, the test result also says "Testing failed: Property 'allCases' must be declared public because it matches a requirement in public protocol 'CaseIterable'". So could you please mark allCases as public? Thanks.

@satoshi-takano satoshi-takano merged commit 143eafa into satoshi-takano:master Nov 1, 2018
@satoshi-takano
Copy link
Owner

@robbiet480 I've merged your pull request and will resolve the CI error myself. Thanks for your pull request!

@robbiet480
Copy link
Contributor Author

@satoshi-takano Sorry about that, got suddenly busy last week. Thanks for merging and fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants