add customize header API #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satoshi-takano
changed the base branch from
master
to
add_customize_header_api
satoshi-takano
changed the base branch from
add_customize_header_api
to
master
|
@puyanlin
Is this all right? |
|
Yes, good job.
This repo is saving my life, thank you.
… On 5 Jan 2017, at 11:31 AM, Satoshi Takano ***@***.***> wrote:
@puyanlin <https://github.com/puyanlin>
Thank you for your pull request.
I think as follows:
It is desireble that handleFetchRequest is private method. <2467e32>
Custom UserAgent specification should be optional. <cf108bb>
Is this all right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#21 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC_m30fJo7YkqZB-RjPm0N1eK2jYqP9Wks5rPGP4gaJpZM4LZspf>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some website needs some header to cheat to skip some page to read content, so we may need a function to allow user be able to customize headers they needed.
thank you.