Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect og:xxx also when order of attributes are reversed. #20

Merged
merged 1 commit into from
Jan 1, 2017
Merged

Detect og:xxx also when order of attributes are reversed. #20

merged 1 commit into from
Jan 1, 2017

Conversation

fumiki
Copy link
Contributor

@fumiki fumiki commented Dec 30, 2016 •
edited
Loading

Update regular expression to match not only

<meta property="og:title" content="foobar" />

, but also

<meta content="foobar" property="og:title" />

@satoshi-takano
Copy link
Owner

@fumiki
Thank you for your pull request.
LGTM 👍

@satoshi-takano satoshi-takano merged commit 125deea into satoshi-takano:master Jan 1, 2017
@fumiki
Copy link
Contributor Author

fumiki commented Jan 1, 2017

Thanks for merge!☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fumiki @satoshi-takano