Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue with non-Latin characters not displaying correctly on OG images using Google Fonts API #318

Merged
merged 5 commits into from
Jul 27, 2024

Conversation

cantpr09ram
Copy link
Contributor

hello-你好-안녕-こんにちは-χαίρετε-hallå

before after
before_jp after_jp
before_cn after_cn

if you want more language support you can add it on your own

const fontsConfig = [
   { name: "Noto Sans JP", font: "Noto+Sans+JP", weight: 400, style: "normal", },
   { name: "Noto Sans JP", font: "Noto+Sans+JP:wght@700", weight: 700, style: "normal", }, 
   { name: "Noto Sans", font: "Noto+Sans", weight: 400, style: "normal" },
   { name: "Noto Sans", font: "Noto+Sans:wght@700", weight: 700, style: "normal", },
  ];

@satnaing
Copy link
Owner

Thanks for your PR @cantpr09ram.
I need to check this in detail along with dependency (Satori) upgrade.
BRB.

@satnaing
Copy link
Owner

satnaing commented Jul 22, 2024

Hello @cantpr09ram
Are you able to build the project?
I've got First argument to DataView constructor must be an ArrayBuffer error when I tried building the project.

Screenshot 2024-07-22 at 8 22 50 PM

cantpr09ram and others added 5 commits July 27, 2024 14:00
Changes made
- resolve conflicts with the main branch
- fix font loading issue in og.png.ts via site.tsx
- add a new section in blog post
@satnaing
Copy link
Owner

Hello @cantpr09ram
I co-authored some changes

  • resolved conflicts with the main branch and rebased
  • fixed font loading issue in og.png.ts via site.tsx
  • added a new section in blog post

Thanks for your contribution.

@satnaing satnaing merged commit 2f82feb into satnaing:main Jul 27, 2024
@cantpr09ram
Copy link
Contributor Author

hi @satnaing

Sorry for the delay in getting back to you. I've been swamped with final exams. Thanks a ton for your project and for merging my changes. It’s much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants