Variable argument maps #919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds a keywords() function to retrieve these maps.
| # The splat argument for this function, if one exists. | ||
| # The first splat argument for this function, if one exists. | ||
| # | ||
| # This could be a lsit of positional arguments, a map of keyword |
Handles argument lists with both args and varargs when passed only the explicitly mentioned arguments.
| if value && keywords.include?(var.underscored_name) | ||
| raise Sass::SyntaxError.new("#{desc} was passed argument $#{var.name} both by position and by name.") | ||
| if callable.splat | ||
| rest = args[callable.args.length..-1] |
There was a problem hiding this comment.
This should be args[callable.args.length..-1] || [] because it's nil when the the number of args is the same.
I pushed a test and fix for this to the branch.
$adjust-by: (alpha: -10%, "blue": 30%);
.color {c: scale-color($color: purple, $red: -20%, $adjust-by...)};Raises the error: But the arglist contains only keywords. I think we should allow arglist passing of the form: something(arg1, arg2, $kwarg1: v1, $kwarg2: v2, $positional_args..., $kwargs...)
// or
something(arg1, arg2, $positional_args..., $kwarg1: v1, $kwarg2: v2, $kwargs...) |
| Maps can be passed as variable arguments, just like lists. For example, if | ||
| `$map` is `(lightness: 10%, blue: -30%)`, you can write `scale-color($color, | ||
| $map...)` and it will do the same thing as `scale-color($color, $lightness: 10%, | ||
| $blue: 30%)`. To pass a variable argument list and map at the same time, just do |
There was a problem hiding this comment.
this example doesn't actually work. I updated it.
|
Landed as a4e9233 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for passing maps as variable arguments and using the
keywords()function to access them.