Fix some number serialization bugs #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to avoid traversing the number string more times than necessary.
This function didn't expect a number ending in ".0", because they're normally filtered out by fuzzyAsInt(). However, they can make it through for very large doubles.
nshahan
approved these changes
May 21, 2019
lib/src/visitor/serialize.dart
Outdated
| return; | ||
| } | ||
|
|
||
| var text = number.toString(); | ||
| if (text.contains("e")) text = _removeExponent(text); | ||
| // Dart and Node both print doubles at least 1e21 using exponentail |
There was a problem hiding this comment.
exponentail --> exponential
There was a problem hiding this comment.
The exponentail is the rightward extension of the graph of x^-2 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.