Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test that uses SyncPackageResolver.loadConfig which also works #169

Conversation

zoechi
Copy link

@zoechi zoechi commented Aug 6, 2017

with relative paths in .packages

@nex3
Copy link
Contributor

nex3 commented Aug 6, 2017

I'm not sure I understand why we're testing this here. Isn't it the responsible for the Dart infrastructure—pkg_config and package_resolver—to ensure that the resolver behaves correctly?

@zoechi
Copy link
Author

zoechi commented Aug 6, 2017

I'm not sure either, but I wasted quite some time to debug dart-sass to get transform_sass working until it turned out the issue is caused by how the .packages config is read.
I built the test for debugging and thought it might be valuable to others to see how the resolver needs to be initialized for this scenario to work.
If you rather not have this in tests, feel free to ignore the PR.

@nex3 nex3 closed this Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants