Fix a crash with nested media rules (#454)

Closes #453
sass · Aug 17, 2018 · 677d781 · 677d781
1 parent c5dff3e
commit 677d781
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 1.12.1
+
+* Don't crash when a media rule contains another media rule followed by a style
+ rule.
+
 ## 1.12.0
 
 ### Dart API

diff --git a/lib/src/visitor/async_evaluate.dart b/lib/src/visitor/async_evaluate.dart
@@ -1012,7 +1012,7 @@ class _EvaluateVisitor
  scopeWhen: node.hasDeclarations);
  _atRootExcludingStyleRule = oldAtRootExcludingStyleRule;
 
- if (!_inStyleRule) {
+ if (!_inStyleRule && _parent.children.isNotEmpty) {
  var lastChild = _parent.children.last;
  lastChild.isGroupEnd = true;
  }

diff --git a/lib/src/visitor/evaluate.dart b/lib/src/visitor/evaluate.dart
@@ -5,7 +5,7 @@
 // DO NOT EDIT. This file was generated from async_evaluate.dart.
 // See tool/synchronize.dart for details.
 //
-// Checksum: 79bb19171b8f5f162f86e3892eddae2c2dad5fbb
+// Checksum: 2bf89d853d3acfa3d7215dc7a6d43aefe0397519
 
 import 'async_evaluate.dart' show EvaluateResult;
 export 'async_evaluate.dart' show EvaluateResult;
@@ -1005,7 +1005,7 @@ class _EvaluateVisitor
  scopeWhen: node.hasDeclarations);
  _atRootExcludingStyleRule = oldAtRootExcludingStyleRule;
 
- if (!_inStyleRule) {
+ if (!_inStyleRule && _parent.children.isNotEmpty) {
  var lastChild = _parent.children.last;
  lastChild.isGroupEnd = true;
  }

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,5 +1,5 @@
 name: sass
-version: 1.12.0
+version: 1.12.1-dev
 description: A Sass implementation in Dart.
 author: Dart Team <[email protected]>
 homepage: https://github.com/sass/dart-sass