fix: when no Assistant Tools are specified, an empty list should be sent #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwhise, when updating an assistant that already has tools, if the list is omitted, no changes will be made and the tools will set.
This was referenced Mar 14, 2024
grulex
pushed a commit
to grulex/go-openai
that referenced
this pull request
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Currently, it is not possible to remove all tools when modifying an assistant because the field will be omitted if empty. With this change, it will now be possible.
Provide OpenAI documentation link
https://platform.openai.com/docs/api-reference/assistants/modifyAssistant#assistants-modifyassistant-tools
Describe your solution
When creating or modifying an assistant, an empty list of tools will be sent instead of omitting the field.
Tests