Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement new fine tuning job API #479

Merged

Conversation

henomis
Copy link
Contributor

@henomis henomis commented Aug 24, 2023

This PR implements new Fine Tuning Job API .

@henomis henomis marked this pull request as draft August 24, 2023 23:26
@henomis henomis marked this pull request as ready for review August 24, 2023 23:26
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #479 (057559a) into master (a14bc10) will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
+ Coverage   97.07%   97.30%   +0.22%     
==========================================
  Files          17       18       +1     
  Lines         719      780      +61     
==========================================
+ Hits          698      759      +61     
  Misses         15       15              
  Partials        6        6              
Files Changed Coverage Δ
fine_tuning_job.go 100.00% <100.00%> (ø)

@henomis henomis marked this pull request as draft August 24, 2023 23:28
@henomis henomis marked this pull request as ready for review August 24, 2023 23:59
@sashabaranov
Copy link
Owner

Hey, thank you so much for coming up with a PR for a new functionality so quickly!

fine_tuning_job.go Outdated Show resolved Hide resolved
if requestParamters != "" {
requestParamters += "&"
}
requestParamters += fmt.Sprintf("limit=%d", *parameters.limit)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please use url.Values here?

Example from https://pkg.go.dev/net/url#Values.Encode

package main

import (
	"fmt"
	"net/url"
)

func main() {
	v := url.Values{}
	v.Add("cat sounds", "meow")
	v.Add("cat sounds", "mew/")
	v.Add("cat sounds", "mau$")
	fmt.Println(v.Encode())

}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sashabaranov sashabaranov merged commit a2ca01b into sashabaranov:master Aug 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants