Update comment for jsonSchema.FunctionDefinition
#441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
=======================================
Coverage 97.03% 97.03%
=======================================
Files 17 17
Lines 709 709
=======================================
Hits 688 688
Misses 15 15
Partials 6 6
|
vvatanabe
approved these changes
Jul 15, 2023
|
@savannahostrowski Thanks for the correction of the comment! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Currently, the comment for the
Parametersproperty in thejsonschema.FunctionDefinitionstruct says that you can pass in a[]byte{}. However, this does not work and you need to usejson.RawMessage()instead.Describe your solution
Just updated the comment :)
Tests
Not applicable!
Additional context
Passing in
[]byte{}leads to base64'd value