move json schema to directory/package #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
=======================================
Coverage 96.95% 96.95%
=======================================
Files 17 17
Lines 690 690
=======================================
Hits 669 669
Misses 15 15
Partials 6 6
|
|
@jmacwhyte thank you for the PR! Would you be up to adding a README example while we are on it? |
sashabaranov
approved these changes
Jun 23, 2023
|
oops, it got clobbered in a rebase + force push :| fwiw it does break the import path of old code (hence updating the tests). I am fine with it but should make a note! |
|
@sashabaranov I've added some details to the README, please let me know if that looks sufficient! @stillmatic I'm not really sure what details to include about import path breaking, but would be happy to add something if you have a suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sashabaranov When discussing #377 you made a comment about separating out the json schema definitions, which I did in a subsequent commit. Although it was added to @stillmatic 's fork before #377 was accepted, it looks like that commit didn't make it into the final merge!
I am including it here for consideration.