Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split integration test using go build tag #392

Conversation

vvatanabe
Copy link
Collaborator

Use go build tags to split integration tests to prevent unexpected integration test runs.

Run tests using:

OPENAI_TOKEN=XXX go test -v -tags=integration ./api_integration_test.go

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #392 (6327049) into master (b095938) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files          17       17           
  Lines         676      676           
=======================================
  Hits          644      644           
  Misses         22       22           
  Partials       10       10           

@vvatanabe
Copy link
Collaborator Author

@sashabaranov Please check it. (Continuation of previous PR #389 .)

Copy link
Owner

@sashabaranov sashabaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you! 🔥

As usual — @gdb @logankilpatrick, would you mind providing us with some credits to run integration tests in CI?

@sashabaranov sashabaranov merged commit 68f9ef9 into sashabaranov:master Jun 19, 2023
3 checks passed
coggsfl added a commit to coggsfl/go-openai that referenced this pull request Jun 19, 2023
split integration test using go build tag (sashabaranov#392)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants