Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added function call info to chat completions #390

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

cem-unuvar
Copy link
Contributor

Function calls are currently inaccessible in chat completion streams. This addresses that issue.

@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Merging #390 (70ab1e7) into master (b095938) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #390   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files          17       17           
  Lines         676      676           
=======================================
  Hits          644      644           
  Misses         22       22           
  Partials       10       10           
Impacted Files Coverage Δ
chat_stream.go 89.28% <ø> (ø)

@jmacwhyte
Copy link
Contributor

@cem-unuvar Have you been able to get function calls to work when streaming from the API? In my tests, it just returned an empty response and no function call information. I had assumed function calls aren't supported when the streaming flag is set to true, but maybe I missed something?

@vvatanabe
Copy link
Collaborator

FYI
#374 (comment)

@cem-unuvar
Copy link
Contributor Author

@jmacwhyte I am running this in prod right now without any issues

@jmacwhyte
Copy link
Contributor

I was able to get it to work! I agree with merging this.

Copy link
Owner

@sashabaranov sashabaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@sashabaranov sashabaranov merged commit 7203770 into sashabaranov:master Jun 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants