Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/internal testing #194

Merged
merged 10 commits into from
Mar 24, 2023
Merged

Refactor/internal testing #194

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d3f442e
added NoError check
rexposadas Mar 21, 2023
0614469
corrected NoError
Mar 21, 2023
b97ddde
has error checks
Mar 21, 2023
a94a6b3
replace more checks
Mar 21, 2023
203051c
Merge branch 'master' into refactor/internal-testing
rexposadas Mar 23, 2023
a2d5d97
Used checks test helper
rexposadas Mar 23, 2023
5c2539d
Used checks test helper
rexposadas Mar 23, 2023
1ad473a
Merge branch 'refactor/internal-testing' of github.com:rexposadas/go-…
rexposadas Mar 23, 2023
35105ce
remove duplicate import
rexposadas Mar 23, 2023
bfdc083
fixed lint issues regarding length of messages
rexposadas Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
has error checks
  • Loading branch information
Rex Posadas committed Mar 21, 2023
commit b97ddde3f3a3fadb5971219697aa797a53e68f5e
4 changes: 1 addition & 3 deletions api_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,7 @@ func TestRequestError(t *testing.T) {
c := NewClientWithConfig(config)
ctx := context.Background()
_, err = c.ListEngines(ctx)
if err == nil {
t.Fatal("ListEngines did not fail")
}
checks.HasError(t, err, "ListEngines did not fail")

var reqErr *RequestError
if !errors.As(err, &reqErr) {
Expand Down
7 changes: 7 additions & 0 deletions internal/test/checks/checks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,10 @@ func NoError(t *testing.T, err error, message ...string) {
t.Error(err, message)
}
}

func HasError(t *testing.T, err error, message ...string) {
t.Helper()
if err == nil {
t.Error(err, message)
}
}