This repository has been archived by the owner on Jul 14, 2023. It is now read-only.
fix: support deep update for one to many composition #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @vobu & @gregorwolf
This pull request fixes the test for deep update that was marked as skip in service.test.js.
During a deep update, CAP deletes in this scenario all Beers, updates the Brewery and then inserts the Beers from the payload. In this case the "values" passed as parameter to the PostgreSQL client is an array of arrays containing the values. That lead to the error message "bind message supplies 1 parameters, but prepared statement "" requires 9".
This is handled correctly in executeInsertCQN, but CAP is in an update context - therefore the executeGenericCQN function is called. The fix is to reroute to executeInsertCQN if the SQL is an insert query.
I also had to modify the deep update service test in order to restore the number of beers for the local-schema test.
I think this should also address the issue #116.
Cheers,
Sebastian