This repository has been archived by the owner on Jul 14, 2023. It is now read-only.
fix: return timestamps, not now() for createdAt and modifiedAt columns #278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @vobu and @gregorwolf,
cds-pg returned NOW() instead of a timestamp for createdAt and modifiedAt columns when used as described in the new InsertResult Beta documentation at https://cap.cloud.sap/docs/node.js/databases#insertresult-beta.
I compared the behaviour of cds-pg vs. HANA and SQLite here: https://answers.sap.com/questions/13569793/api-of-insert-query-results-for-cap-nodejs.html
I have to admit I don't understand, why the locale and txTimestamp parameters were omitted from the exported functions in lib/pg/execute.js, but adding them fixed the issue and all tests are completed successfully.
Cheers,
Sebastian