This repository has been archived by the owner on Jul 14, 2023. It is now read-only.
Fix for Issue #263: Fixed tags in default-env.json example #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed the tags in the default-env.json example to match the template in the CAP application used for testing.
I have also dug deeper into CAP to understand, what happens. The root cause, why the "plain" dialect is important in the tags of the VACP services is, that the configuration for the "postgres" service is merged with the "db" service - and when the VACP settings are merged, the current service name is "db" - not "postgres".
The magic happens in
_add_vcap_services_toof @sap/cds/lib/env/index.js.I can amend the pull request and try to explain the matching of the services is more detail if required.
Kind regards,
Sebastian