Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(corel): update discard version dialog #7121

Merged
merged 1 commit into from
Jul 11, 2024
Merged

feat(corel): update discard version dialog #7121

merged 1 commit into from
Jul 11, 2024
+56 −9

Conversation

pedrobonamin
Copy link
Contributor

Description

Updates discard version dialog to match with the UI, discard functionality was included in base branch.
Screenshot 2024-07-10 at 12 00 06

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner July 10, 2024 10:11
@pedrobonamin pedrobonamin requested review from bjoerge and removed request for a team July 10, 2024 10:11
@vercel Vercel
Copy link

vercel bot commented Jul 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 10:31am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 10:31am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 10:31am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 10:31am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 10:31am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 10:31am

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@pedrobonamin pedrobonamin requested a review from a team as a code owner July 10, 2024 10:21
@pedrobonamin pedrobonamin requested a review from a team July 10, 2024 10:21
@pedrobonamin pedrobonamin removed request for a team July 10, 2024 10:23
RitaDias
RitaDias approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pedrobonamin pedrobonamin merged commit 37e5b9f into corel-24 Jul 11, 2024
39 of 42 checks passed
@pedrobonamin pedrobonamin deleted the corel-48 branch July 11, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RitaDias RitaDias RitaDias approved these changes

@bjoerge bjoerge Awaiting requested review from bjoerge bjoerge was automatically assigned from sanity-io/sdk

@juice49 juice49 Awaiting requested review from juice49

@jordanl17 jordanl17 Awaiting requested review from jordanl17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedrobonamin @RitaDias