feat(copy dataset): Allow API to determine if target dataset exists #3289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r a copy job is in progress.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…r a copy job is in progress.
…r a copy job is in progress.
j33ty
approved these changes
May 18, 2022
dcilke
reviewed
May 18, 2022
Comment on lines
-145
to
-147
| if (existingDatasets.includes(targetDatasetName)) { | ||
| throw new Error(`Target dataset "${targetDatasetName}" already exists`) | ||
| } |
There was a problem hiding this comment.
Do we need to make any changes to the error logging?
There was a problem hiding this comment.
No, it gets caught in the same set of statements we already use.
rexxars
pushed a commit
that referenced
this pull request
May 30, 2022
bjoerge
pushed a commit
that referenced
this pull request
Sep 21, 2022
bjoerge
pushed a commit
that referenced
this pull request
Sep 23, 2022
bjoerge
pushed a commit
that referenced
this pull request
Sep 26, 2022
bjoerge
pushed a commit
that referenced
this pull request
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow API to determine if the target dataset exists or if a copy job is currently in progress.
New functionality in API to determine the difference between existing dataset and running job.
Stops confusion when a copy job is in progress but the UI says "dataset name already exists".
What to review
Simply removing a check against local storage.
Notes for release
New functionality in API to determine the difference between existing dataset and running job.
CLI will now let the API determine the state of the target dataset.