Validation and Custom-Validator throws error since flow 6 #50
Conversation
|
@skurfuerst hello hello? |
There was a problem hiding this comment.
Hey again ☀️
Thank you so much for your contribution! It's awesome to have it ❤️ Sorry for the long delay in answering, and thanks for pinging me on slack to highlight this PR!
I've just gone through the code, and I suggest some adjustments for the following goal:
- I'd love to keep the
RegistrationFlowValidationServiceInterfaceas it is right now - as this is part of the public API of the package.
The master branch of the package is for Flow 6.x; so there's no problem at all to rely on Flow 6 here and fix this behavior directly, without worrying about older Flow releases.
Please ping me again on Slack once you have done some adjustments, as this will help me to prioritize the review in a quick manner 👍
Thanks again for your work,
Sebastian
| * @Flow\Inject | ||
| * @var TokenAndProviderFactoryInterface | ||
| */ | ||
| protected $tokenAndProviderFactoryInterface; |
There was a problem hiding this comment.
I'd call this variable $tokenAndProviderFactory - we usually do not add the interface postfix on variable names :)
| if ($this->objectManager->isRegistered(RegistrationFlow6ValidationServiceInterface::class)) { | ||
| $instance = $this->objectManager->get(RegistrationFlow6ValidationServiceInterface::class); | ||
| $instance->validateRegistrationFlow6($value, $this->getResult()); | ||
| } |
There was a problem hiding this comment.
(read comment about getResult first)
... then, you can skip this block, because the RegistrationFlowValidationServiceInterface will work as usual before :)
README.md
Outdated
| // This is an example of your own custom validation logic. | ||
| if ($registrationFlow->getAttributes()['agb'] !== '1') { | ||
| $validator->getResult()->forProperty('attributes.terms')->addError(new \Neos\Flow\Validation\Error('You need to accept the terms and conditions.')); | ||
| $validatorResult->forProperty('attributes.terms')->addError(new \Neos\Flow\Validation\Error('You need to accept the terms and conditions.')); |
There was a problem hiding this comment.
... then these changes here are obsolete :)
There was a problem hiding this comment.
Habe die README rückgängig gemacht.
|
@skurfuerst Besten Dank! Habe die Änderungen einmal vorgenommen. Habe es in meinem Projekt getestet - funktionieren gut 👍 |
| /** | ||
| * @api | ||
| */ | ||
| interface RegistrationFlow6ValidationServiceInterface |
There was a problem hiding this comment.
could you still remove the one obsolete interface? :-) :-)
|
thanks, looks great :) Merging! |
@skurfuerst
Hi there,
this is my first pull request - please be gentle :)
Cheers
Göks