Nick/tenmat constructors #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add isequal
* From_data should only accept vector or matrix
* Add isequal utility method to tenmat
dmdunla
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #214 but not the full documentation task since I ran out of steam.
Sptenmat is pretty straightforward based on our other constructors. Tenmat was complicated because we had expanded it to take in ANY array regardless of layout and we would try to reshape it for the end user. I constrained it to taking data that is already matricized correctly. My expectation is most people will generate a tenmat from an existing tensors as an intermediate for some operation rather than directly.
I also fixed the dimension inference here and provided an example #102 (comment).
📚 Documentation preview 📚: https://pyttb--293.org.readthedocs.build/en/293/