Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nick/pre commit #284

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Nick/pre commit #284

merged 3 commits into from
Nov 3, 2023

Conversation

ntjohnson1
Copy link
Collaborator

@ntjohnson1 ntjohnson1 commented Oct 22, 2023

Small ergonomics focused PR to resolve #280.

  1. Adds pre-commit to dev deps. Makes it easier for instance to run pre-commit run --all-files if CI fails. Hooks are still opt-in
  2. Some minor cleanup in our pytest infra. Moves the ini to pyproject.toml which has been supported for a few years. Also removes the indevelopment marker that we used internally for developing initial capability but hasn't been used since published to github.

📚 Documentation preview 📚: https://pyttb--284.org.readthedocs.build/en/284/

* Finally get around to removing indevelopment mark which hasn't really been relevant in years
@ntjohnson1 ntjohnson1 marked this pull request as ready for review October 22, 2023 17:24
@dmdunla dmdunla merged commit e62cc43 into sandialabs:main Nov 3, 2023
8 checks passed
@ntjohnson1 ntjohnson1 deleted the nick/pre_commit branch November 3, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include pre-commit in dev requirements?
2 participants