Gcp opt tutorial fixes #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enforced by our typing (uncertain why this wasn't an issue earlier)
jeremy-myers
approved these changes
Sep 21, 2023
dmdunla
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #251 and #252. Testing for logging is a little brittle/would require some more thought. I think the tutorials should serve to capture whatever formatting issue I had before with the inf check. I think these are mostly helpful to unblock the tutorial and if people felt strongly could file an issue to follow up with better testing.
📚 Documentation preview 📚: https://pyttb--255.org.readthedocs.build/en/255/