Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sptensor: output of comparison operators should have bool values #285

Open
dmdunla opened this issue Nov 1, 2023 · 0 comments
Open

sptensor: output of comparison operators should have bool values #285

dmdunla opened this issue Nov 1, 2023 · 0 comments
Milestone

Comments

@dmdunla
Copy link
Collaborator

dmdunla commented Nov 1, 2023

Although #269 fixed the output for logical_* methods, the comparison operators in sptensor currently output float values and not bool values.

For consistency with other tensor classes and the logical_* methods, this should change to outputting bool values.

>>> import pyttb as ttb
>>> import numpy as np
>>> S = ttb.sptensor(shape=(2,2))
>>> S[1,1] = 1.0
>>> S > 0
sparse tensor of shape (2, 2) with 1 nonzeros
[1, 1] = 1.0
>>> S >= 0
sparse tensor of shape (2, 2) with 4 nonzeros
[1, 1] = 1.0
[0, 0] = 1.0
[0, 1] = 1.0
[1, 0] = 1.0
@dmdunla dmdunla added this to the v2.0.0 milestone Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant