Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #256 and #257 but maybe raises more questions than it answers. It matches what you described as expected behavior. (Indicator tensors with 1.0, 0.0)
It raises the question on if we should track the dtype (could be a hidden variable or a property). Or even more explicitly could be set when constructing the tensor (I kind of hacked the vals in the sptensor to make things make sense; however would be nice to take a dtype argument on construction).
You mentioned in the issue we don't do boolean tensors but for equality we currently do. Should those also get the same indicator treatment?
📚 Documentation preview 📚: https://pyttb--269.org.readthedocs.build/en/269/