Corrects conditional compilation problem on ESP8266 and ESP32 #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 0.6.0 introduced a mechanism to supply the ICACHE_RAM_ATTR prefix to the onDio0Rise() interrupt service routine when compiling for ESP32 or ESP8266 boards. As written, "#ifdef ESP8266 || ESP32" produces "warning: extra tokens at end of #ifdef directive" when compiling in the Arduino IDE 1.8.9. If the board is an ESP8266 then ISR_PREFIX has the value ICACHE_RAM_ATTR (correct) but if the board is an ESP32, ISR_PREFIX is null (incorrect) This PR proposes alternative syntax "#if (ESP8266 || ESP32)" which compiles without warning and provides ICACHE_RAM_ATTR to both ESP8266 and ESP32 boards.
|
LGTM |
|
Merged and 0.6.1 released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 0.6.0 introduced a mechanism to supply the ICACHE_RAM_ATTR
prefix to the onDio0Rise() interrupt service routine when compiling
for ESP32 or ESP8266 boards. As written, "#ifdef ESP8266 || ESP32"
produces "warning: extra tokens at end of #ifdef directive" when
compiling in the Arduino IDE 1.8.9. If the board is an ESP8266 then
ISR_PREFIX has the value ICACHE_RAM_ATTR (correct) but if the board is
an ESP32, ISR_PREFIX is null (incorrect) This PR proposes alternative
syntax "#if (ESP8266 || ESP32)" which compiles without warning and
provides ICACHE_RAM_ATTR to both ESP8266 and ESP32 boards.