Fixes a bug when view gets deallocated & showsPullToRefresh == NO #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d while showsPullToRefresh == NO
|
I had the same problem and I eventually removed the contentSize observer when showsPullToRefresh is set to NO. See #133 . It's very similar to your fix but at a different time. Not sure which one is better and if there're any side effects. |
|
Indeed. I haven't had enough time to jump to the code, but as far as I can see this observer is not need when showsPullToRefresh is set to NO. I thought I had tried your fix before mine without success. But it works fine, and seems more logic this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observers were not correctly removed if
showsPullToRefreshequals to NO.This error what appearing :
"An instance 0x78b6e00 of class UITableView was deallocated while key value observers were still registered with it. Observation info was leaked, and may even become mistakenly attached to some other object. Set a breakpoint on NSKVODeallocateBreak to stop here in the debugger."
This fixes the issue.
Cheers