Fix lint errors

samuelmeuli · Mar 20, 2020 · c0af398 · c0af398
1 parent 9edbde8
commit c0af398
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/convert.go b/convert.go
@@ -8,6 +8,7 @@ import (
  "html/template"
  "io"
  "io/ioutil"
+ "path/filepath"
  "strings"
 
  "github.com/alecthomas/chroma"
@@ -94,7 +95,7 @@ func convertErrorOutput(output output) template.HTML {
  }
 
  // Convert ANSI colors to HTML
- var linesHTML []string
+ linesHTML := []string{}
  for _, tracebackLine := range output.Traceback {
  lineHTML := terminal.Render([]byte(tracebackLine))
  linesHTML = append(linesHTML, string(lineHTML))
@@ -196,7 +197,7 @@ func convertOutput(output output) template.HTML {
 // err := nbtohtml.ConvertFile(notebookHTML, notebookPath)
 func ConvertFile(writer io.Writer, notebookPath string) error {
  // Read file
- fileContent, err := ioutil.ReadFile(notebookPath)
+ fileContent, err := ioutil.ReadFile(filepath.Clean(notebookPath))
  if err != nil {
  return fmt.Errorf("could not read Jupyter Notebook file at %s", notebookPath)
  }

diff --git a/parse.go b/parse.go
@@ -5,10 +5,10 @@ import (
 )
 
 // Documentation of the Jupyter Notebook JSON format: https://ipython.org/ipython-doc/3/notebook/nbformat.html
-// (VCS: https://github.com/ipython/ipython-doc/blob/e9c83570cf3dea6d7a6b178ee59869b4f441220f/3/notebook/nbformat.html)
+// (VCS: https://github.com/ipython/ipython-doc/blob/e9c83570cf3dea6d7a6b178ee59869b4f441220f/3/notebook/nbformat.html).
 
-// outputData can contain the cell output in various data types.
-// Source: https://github.com/jupyter/nbconvert/blob/c837a22d44d98f6a58d1934bd85af1506df48f21/nbconvert/utils/base.py#L16
+// outputData can contain the cell output in various data types. Source:
+// https://github.com/jupyter/nbconvert/blob/c837a22d44d98f6a58d1934bd85af1506df48f21/nbconvert/utils/base.py#L16.
 type outputData struct {
  TextHTML []string `json:"text/html,omitempty"`
  ApplicationPDF *string `json:"application/pdf,omitempty"`

diff --git a/test_data.go b/test_data.go
@@ -72,7 +72,7 @@ const testNotebookString = `{
  "output_type": "display_data",
  "data": {
  "image/svg+xml": [
- "<svg id=\"star\" xmlns=\"https://www.w3.org/2000/svg\" width=\"255\" height=\"240\" viewBox=\"0 0 51 48\">\n",
+ "<svg xmlns=\"https://www.w3.org/2000/svg\" width=\"255\" height=\"240\">\n",
  "<path d=\"M25 1l6 17h18L35 29l5 17-15-10-15 10 5-17L1 18h18z\"/>\n",
  "</svg>"
  ]
@@ -194,7 +194,7 @@ var testDisplayDataSVGOutput = output{
  OutputType: "display_data",
  Data: outputData{
  ImageSVGXML: []string{
- "<svg id=\"star\" xmlns=\"https://www.w3.org/2000/svg\" width=\"255\" height=\"240\" viewBox=\"0 0 51 48\">\n",
+ "<svg xmlns=\"https://www.w3.org/2000/svg\" width=\"255\" height=\"240\">\n",
  "<path d=\"M25 1l6 17h18L35 29l5 17-15-10-15 10 5-17L1 18h18z\"/>\n",
  "</svg>",
  },