Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added is Odd #63

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added is Odd #63

wants to merge 2 commits into from

Conversation

GTSchunk
Copy link

Added is-odd function to be able to return weather a number is odd

@GTSchunk GTSchunk changed the title Update index.js Added is Odd Aug 17, 2021
@GTSchunk
Copy link
Author

#61

@GTSchunk GTSchunk mentioned this pull request Aug 17, 2021
Closed
@Hocuri
Copy link

Hocuri commented Aug 17, 2021

Please don't put briefness over readability and correctness.

I'm not sure if it's possible to find out whether a number is odd this way. It would be better to check all numbers one by one, just to be sure not to miss one.

@GTSchunk
Copy link
Author

Please don't put briefness over readability and correctness.

I'm not sure if it's possible to find out whether a number is odd this way. It would be better to check all numbers one by one, just to be sure not to miss one.

That is a good point. I will work on update to hopefully include the test cases done in the original in order to increase readability.

@GTSchunk
Copy link
Author

Please don't put briefness over readability and correctness.

I'm not sure if it's possible to find out whether a number is odd this way. It would be better to check all numbers one by one, just to be sure not to miss one.

I have made the adjustments hopefully this will be more accurate

Copy link

@Hocuri Hocuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@hexonthebeach
Copy link

we can use https://github.com/samuelmarina/is-odd for this already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants