Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added latest strings to de-DE and a diffchecker #256

Merged
merged 7 commits into from
Mar 28, 2020
Merged

Added latest strings to de-DE and a diffchecker #256

merged 7 commits into from
Mar 28, 2020

Conversation

LauraWebdev
Copy link
Contributor

@LauraWebdev LauraWebdev commented Mar 2, 2020

I've just added all missing strings to de-DE.

The second commit is a small diff checker script for locales that shows which strings changed and which are new. Very useful to quickly see which strings need to be added (previously it was a real PITA to look through both files to check the differences).

Usage: npm run locale:diff -- de-DE

Copy link
Owner

@samuelmaddock samuelmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the script, looks useful!

A couple of requests before merging:

  • Move script from metastream-app/localeDiff.js to metastream-app/scripts/localeDiff.js
  • Remove package-lock.json and install using yarn instead of npm

packages/metastream-app/package.json Outdated Show resolved Hide resolved
@LauraWebdev
Copy link
Contributor Author

I've pushed a few commits for your requests

@samuelmaddock samuelmaddock merged commit 00f22d3 into samuelmaddock:master Mar 28, 2020
@samuelmaddock
Copy link
Owner

Thanks for making those changes. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants