made it so that the load and dump functions in the speech.nvgt include also saves if a screenreader should be used or not #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… this change takes in to account the users preferense of screenreader enabled or disabled
…ready created lists
* any previously saved settings would have caused a runtime error, as the use_sr boolean at position 4 in the array didn't exist in previously saved settings. * In some cases it's possible that people might want to save multiple different tts_voice objects, and in such cases, they don't want to store the screen reader usage property more than once. Thus, we add a boolean to dump_tts_config, false by default, that can enable this feature. * We save the use_sr boolean in 1 byte that is 1 or 0, rather than 4 or 5 (true/false)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the change is a bit rudamentary using an if statement to determine the property in question do to me not finding a parse bool function