fastbrili: Conformant float printing #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this change lgtm. Probably shoulda been using clang-format to force spaces over tabs in this but that's a different problem |
|
OK, sounds great! Thanks, @charles-rs. Sorry for the tabs/spaces mixture crimes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #300 (comment), the fastbrili interpreter just needed more conformant float printing to pass the benchmarks test suite. Now all 70 benchmarks match the baseline with
turnt -e fastbrili benchmarks/**/*.bril!Other than my unforgivable use of spaces instead of tabs, does this look OK to you, @charles-rs?
Remaining things on the to-do list here include: