Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks #238

Merged
merged 5 commits into from
Jan 14, 2023
Merged

Tweaks #238

merged 5 commits into from
Jan 14, 2023

Conversation

Pat-Lafon
Copy link
Contributor

Just some small tweaks

  • Up crate versions for clap and regex
  • Feature gate brilirs shell completions. I think these are really cool, but they are a bit finicky(especially being located in the build script) so I've hidden this behind a feature flag for those who want it.
  • Derive PartialEq and Eq when possible on the rest of bril-rs structs

@sampsyo
Copy link
Owner

sampsyo commented Jan 14, 2023

Super nice; thanks!! I agree with feature-gating the completions; like you said, they are nice to have but weirdly complicated for what they are (nice to have).

@sampsyo sampsyo merged commit 3312b4a into sampsyo:main Jan 14, 2023
@Pat-Lafon Pat-Lafon deleted the tweaks branch January 15, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pat-Lafon @sampsyo