Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "Invalid data cell" issue #8

Merged
merged 3 commits into from
May 12, 2023
Merged

Conversation

SyLi9527
Copy link
Contributor

@SyLi9527 SyLi9527 commented May 5, 2023

Thank you so much for the great work.

I encountered the same issue too. After running some tests, I notice that one problem might be originating from this line. The loadStructure function always needs to be executed asynchronously, but an async-await is missing.

Another point to consider is that both the first and second useEffect hooks run during the first rendering. Since they request the same resource, the requsets are disordered. You can find more details by checking the "Network" tab in the developer tools. So I add a state to avoid fecthing the same protein at first rendering.

With the code I committed, it works well on [email protected] for me and issue #5 and #3 may be fixed :)

@SyLi9527
Copy link
Contributor Author

SyLi9527 commented May 7, 2023

I also noticed if you're not using the original interface and have set useInterface={false} or haven't set useInterface at all, you may need to specify the width and height in the parent component. Otherwise, you may encounter the issue WebGL-000045C400394000] GL_INVALID_FRAMEBUFFER_OPERATION: Draw framebuffer is incomplete. I don't know if it's only my problem or others also get this.

@samirelanduk samirelanduk merged commit b5f5a2d into samirelanduk:master May 12, 2023
@samirelanduk
Copy link
Owner

Thanks so much for this - I had noticed this error too, this is a big help. Will make an NPM release for this shortly.

@samirelanduk samirelanduk mentioned this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants