Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sitemap.xml for SEO #2

Merged
merged 1 commit into from
Jun 9, 2019

Conversation

jookwang-park
Copy link
Contributor

How do you think about creating a sitemap.xml file for the Google Search Engine?

I'm using it already, check it out. Here is a result of generating a sitemap.xml

@samarsault
Copy link
Owner

samarsault commented Jun 8, 2019

Nice addition. I think an option to toggle the sitemap in _config.yml would be a useful addition.

@jookwang-park
Copy link
Contributor Author

Thank you for your comment. I have the following questions.

  1. How do you think about to add a sitemap option in _config.yml globally or in plainwhite section?
  2. If a sitemap option is set to false, what sitemap.xml content will be rendered?

@samarsault
Copy link
Owner

  1. In the plainwhite section
  2. You could do something like this in the sitemap.xml file:
{%-if site.plainwhite.sitemap -%}
    // generated content
{%- endif -%}

@jookwang-park
Copy link
Contributor Author

jookwang-park commented Jun 9, 2019

I added the sitemap option. The default 'sitemap' option value is true. If necessary, you can change the default value! And, Maybe the sitemap option should be added to the README file?

Best regards.

@samarsault
Copy link
Owner

Yeah, add it to the README file and squash your commits into one so that I could proceed with the merge.

@jookwang-park
Copy link
Contributor Author

I write a sitemap manual to the README and squash my commits. Check it out please.

@samarsault
Copy link
Owner

Great!

@samarsault samarsault merged commit 3fb6984 into samarsault:master Jun 9, 2019
qhahd78 added a commit to qhahd78/qhahd78.github.io that referenced this pull request Aug 1, 2020
qhahd78 added a commit to qhahd78/qhahd78.github.io that referenced this pull request Aug 1, 2020
qhahd78 added a commit to qhahd78/qhahd78.github.io that referenced this pull request Aug 1, 2020
qhahd78 added a commit to qhahd78/qhahd78.github.io that referenced this pull request Aug 1, 2020
qhahd78 added a commit to qhahd78/qhahd78.github.io that referenced this pull request Aug 1, 2020
qhahd78 added a commit to qhahd78/qhahd78.github.io that referenced this pull request Aug 1, 2020
qhahd78 added a commit to qhahd78/qhahd78.github.io that referenced this pull request Aug 1, 2020
qhahd78 added a commit to qhahd78/qhahd78.github.io that referenced this pull request Aug 1, 2020
qhahd78 added a commit to qhahd78/qhahd78.github.io that referenced this pull request Aug 1, 2020
qhahd78 added a commit to qhahd78/qhahd78.github.io that referenced this pull request Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants