Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to YEL calculator #62

Merged
merged 1 commit into from
Sep 19, 2021
Merged

Conversation

omidmaldar
Copy link
Contributor

This pr

  • Fixes the target of link to YEL calculator. The existing one seems to be broken (shows 404).
  • It also adjusts the minimum and maximum for the YEL income to show their exact amount.

Here are two screenshots that show the results on the calculator:

Minimum_YEL

minimum_YEL

Maximum YEL

maximum_YEL

All the following conditions are met:

  • I have ensured that my PR respects the target audience of this guide 👩‍💻👨‍💻
  • I have read this guide from beginning to the end to ensure that my PR respects the integrity of the guide as a whole 💯
  • I have ensured that my PR respects the strong opinions upon which the guide is based. One example would be this 🤝

Thank you!

@sam-hosseini
Copy link
Owner

@allcontributors add @omidmaldar to contributors for doc

@allcontributors
Copy link
Contributor

@sam-hosseini

I've put up a pull request to add @omidmaldar! 🎉

@sam-hosseini
Copy link
Owner

Hi Omid!

Thank you for the detailed explanations of what the PR does and the fixes 👍🏼

@sam-hosseini sam-hosseini merged commit a839a46 into sam-hosseini:main Sep 19, 2021
@omidmaldar omidmaldar deleted the patch-2 branch September 26, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants