-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minecraft role main.yml #209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added `minecraft_dns_proxy: "false"` to DNS section of the role. For anyone that has Proxy enabled, this role will not work at all as is. I'm sure it would be fine if we added it as `minecraft_dns_proxy: "{{ dns.proxied }}"` as long as we update the docs?
owine
requested changes
Dec 22, 2022
@RaneyDazed Are you planning on finishing this before we freeze the master / main branch? |
owine
added a commit
that referenced
this pull request
Dec 27, 2022
* Update main.yml added `minecraft_dns_proxy: "false"` to DNS section of the role. For anyone that has Proxy enabled, this role will not work at all as is. I'm sure it would be fine if we added it as `minecraft_dns_proxy: "{{ dns.proxied }}"` as long as we update the docs? * Fix boolean Co-authored-by: owine <[email protected]>
maximuskowalski
pushed a commit
to maximuskowalski/Sandbox
that referenced
this pull request
Dec 28, 2022
* Update main.yml added `minecraft_dns_proxy: "false"` to DNS section of the role. For anyone that has Proxy enabled, this role will not work at all as is. I'm sure it would be fine if we added it as `minecraft_dns_proxy: "{{ dns.proxied }}"` as long as we update the docs? * Fix boolean Co-authored-by: owine <[email protected]>
maximuskowalski
added a commit
that referenced
this pull request
Dec 28, 2022
* t3 adguard * feat(uptime-kuma): use PUID/PGID & protect with authelia by default (#211) * fix(uptime-kuma): use PUID/PGID for docker and reset perms * fix(migrator): remove unnecessary code for perms reset * feat(uptime-kuma): protect under authelia by default * feat(uptime-kuma): exclude endpoints for public status pages * Update main.yml minor formatting * Uptime Kuma: Recurse folder permissions Co-authored-by: Max Kowalski <[email protected]> Co-authored-by: owine <[email protected]> * Update minecraft role main.yml (#209) * Update main.yml added `minecraft_dns_proxy: "false"` to DNS section of the role. For anyone that has Proxy enabled, this role will not work at all as is. I'm sure it would be fine if we added it as `minecraft_dns_proxy: "{{ dns.proxied }}"` as long as we update the docs? * Fix boolean Co-authored-by: owine <[email protected]> * make actual adguard commit make actual adguard commit Co-authored-by: JigSaw <[email protected]> Co-authored-by: owine <[email protected]> Co-authored-by: CHAIR <[email protected]>
maximuskowalski
added a commit
that referenced
this pull request
Dec 28, 2022
* t3 adguard * feat(uptime-kuma): use PUID/PGID & protect with authelia by default (#211) * fix(uptime-kuma): use PUID/PGID for docker and reset perms * fix(migrator): remove unnecessary code for perms reset * feat(uptime-kuma): protect under authelia by default * feat(uptime-kuma): exclude endpoints for public status pages * Update main.yml minor formatting * Uptime Kuma: Recurse folder permissions Co-authored-by: Max Kowalski <[email protected]> Co-authored-by: owine <[email protected]> * Update minecraft role main.yml (#209) * Update main.yml added `minecraft_dns_proxy: "false"` to DNS section of the role. For anyone that has Proxy enabled, this role will not work at all as is. I'm sure it would be fine if we added it as `minecraft_dns_proxy: "{{ dns.proxied }}"` as long as we update the docs? * Fix boolean Co-authored-by: owine <[email protected]> * make actual adguard commit make actual adguard commit * Adminer t3 update * airdcpp t3 update * airsonic t3 update * test airsonic java options garbage performance - cant change default pass * Alltube - t3 update * alternatrr t3 update * apprise t3 update check web auth * archivebox t3 update no sso * aria2_ng audiobookshelf autobrr t3 updates Co-authored-by: JigSaw <[email protected]> Co-authored-by: owine <[email protected]> Co-authored-by: CHAIR <[email protected]>
maximuskowalski
added a commit
that referenced
this pull request
Dec 28, 2022
* t3 adguard * feat(uptime-kuma): use PUID/PGID & protect with authelia by default (#211) * fix(uptime-kuma): use PUID/PGID for docker and reset perms * fix(migrator): remove unnecessary code for perms reset * feat(uptime-kuma): protect under authelia by default * feat(uptime-kuma): exclude endpoints for public status pages * Update main.yml minor formatting * Uptime Kuma: Recurse folder permissions Co-authored-by: Max Kowalski <[email protected]> Co-authored-by: owine <[email protected]> * Update minecraft role main.yml (#209) * Update main.yml added `minecraft_dns_proxy: "false"` to DNS section of the role. For anyone that has Proxy enabled, this role will not work at all as is. I'm sure it would be fine if we added it as `minecraft_dns_proxy: "{{ dns.proxied }}"` as long as we update the docs? * Fix boolean Co-authored-by: owine <[email protected]> * make actual adguard commit make actual adguard commit * Adminer t3 update * airdcpp t3 update * airsonic t3 update * test airsonic java options garbage performance - cant change default pass * Alltube - t3 update * alternatrr t3 update * apprise t3 update check web auth * archivebox t3 update no sso * aria2_ng audiobookshelf autobrr t3 updates * beets booksonic bookstack t3 update * booksonic add base url * Revert "booksonic add base url" This reverts commit 772ce83. * calibre caliweb changedetection cherry code_server comixstreamer comixed t3 updates Co-authored-by: JigSaw <[email protected]> Co-authored-by: owine <[email protected]> Co-authored-by: CHAIR <[email protected]>
maximuskowalski
added a commit
that referenced
this pull request
Dec 29, 2022
* t3 adguard * feat(uptime-kuma): use PUID/PGID & protect with authelia by default (#211) * fix(uptime-kuma): use PUID/PGID for docker and reset perms * fix(migrator): remove unnecessary code for perms reset * feat(uptime-kuma): protect under authelia by default * feat(uptime-kuma): exclude endpoints for public status pages * Update main.yml minor formatting * Uptime Kuma: Recurse folder permissions Co-authored-by: Max Kowalski <[email protected]> Co-authored-by: owine <[email protected]> * Update minecraft role main.yml (#209) * Update main.yml added `minecraft_dns_proxy: "false"` to DNS section of the role. For anyone that has Proxy enabled, this role will not work at all as is. I'm sure it would be fine if we added it as `minecraft_dns_proxy: "{{ dns.proxied }}"` as long as we update the docs? * Fix boolean Co-authored-by: owine <[email protected]> * make actual adguard commit make actual adguard commit * Adminer t3 update * airdcpp t3 update * airsonic t3 update * test airsonic java options garbage performance - cant change default pass * Alltube - t3 update * alternatrr t3 update * apprise t3 update check web auth * archivebox t3 update no sso * aria2_ng audiobookshelf autobrr t3 updates * beets booksonic bookstack t3 update * booksonic add base url * Revert "booksonic add base url" This reverts commit 772ce83. * calibre caliweb changedetection cherry code_server comixstreamer comixed t3 updates * booksonic dashy deemix delugevpn docspell dozzle duplicati t3 updates * Add missing role tag - duplicati Co-authored-by: JigSaw <[email protected]> Co-authored-by: owine <[email protected]> Co-authored-by: CHAIR <[email protected]>
maximuskowalski
added a commit
that referenced
this pull request
Dec 29, 2022
* t3 adguard * feat(uptime-kuma): use PUID/PGID & protect with authelia by default (#211) * fix(uptime-kuma): use PUID/PGID for docker and reset perms * fix(migrator): remove unnecessary code for perms reset * feat(uptime-kuma): protect under authelia by default * feat(uptime-kuma): exclude endpoints for public status pages * Update main.yml minor formatting * Uptime Kuma: Recurse folder permissions Co-authored-by: Max Kowalski <[email protected]> Co-authored-by: owine <[email protected]> * Update minecraft role main.yml (#209) * Update main.yml added `minecraft_dns_proxy: "false"` to DNS section of the role. For anyone that has Proxy enabled, this role will not work at all as is. I'm sure it would be fine if we added it as `minecraft_dns_proxy: "{{ dns.proxied }}"` as long as we update the docs? * Fix boolean Co-authored-by: owine <[email protected]> * make actual adguard commit make actual adguard commit * Adminer t3 update * airdcpp t3 update * airsonic t3 update * test airsonic java options garbage performance - cant change default pass * Alltube - t3 update * alternatrr t3 update * apprise t3 update check web auth * archivebox t3 update no sso * aria2_ng audiobookshelf autobrr t3 updates * beets booksonic bookstack t3 update * booksonic add base url * Revert "booksonic add base url" This reverts commit 772ce83. * calibre caliweb changedetection cherry code_server comixstreamer comixed t3 updates * booksonic dashy deemix delugevpn docspell dozzle duplicati t3 updates * Add missing role tag - duplicati * calibres Co-authored-by: JigSaw <[email protected]> Co-authored-by: owine <[email protected]> Co-authored-by: CHAIR <[email protected]>
maximuskowalski
added a commit
that referenced
this pull request
Dec 29, 2022
* t3 adguard * feat(uptime-kuma): use PUID/PGID & protect with authelia by default (#211) * fix(uptime-kuma): use PUID/PGID for docker and reset perms * fix(migrator): remove unnecessary code for perms reset * feat(uptime-kuma): protect under authelia by default * feat(uptime-kuma): exclude endpoints for public status pages * Update main.yml minor formatting * Uptime Kuma: Recurse folder permissions Co-authored-by: Max Kowalski <[email protected]> Co-authored-by: owine <[email protected]> * Update minecraft role main.yml (#209) * Update main.yml added `minecraft_dns_proxy: "false"` to DNS section of the role. For anyone that has Proxy enabled, this role will not work at all as is. I'm sure it would be fine if we added it as `minecraft_dns_proxy: "{{ dns.proxied }}"` as long as we update the docs? * Fix boolean Co-authored-by: owine <[email protected]> * make actual adguard commit make actual adguard commit * Adminer t3 update * airdcpp t3 update * airsonic t3 update * test airsonic java options garbage performance - cant change default pass * Alltube - t3 update * alternatrr t3 update * apprise t3 update check web auth * archivebox t3 update no sso * aria2_ng audiobookshelf autobrr t3 updates * beets booksonic bookstack t3 update * booksonic add base url * Revert "booksonic add base url" This reverts commit 772ce83. * calibre caliweb changedetection cherry code_server comixstreamer comixed t3 updates * booksonic dashy deemix delugevpn docspell dozzle duplicati t3 updates * Add missing role tag - duplicati * calibres * E's and F's - T3 updates Co-authored-by: JigSaw <[email protected]> Co-authored-by: owine <[email protected]> Co-authored-by: CHAIR <[email protected]>
maximuskowalski
added a commit
that referenced
this pull request
Jan 3, 2023
* t3 adguard * feat(uptime-kuma): use PUID/PGID & protect with authelia by default (#211) * fix(uptime-kuma): use PUID/PGID for docker and reset perms * fix(migrator): remove unnecessary code for perms reset * feat(uptime-kuma): protect under authelia by default * feat(uptime-kuma): exclude endpoints for public status pages * Update main.yml minor formatting * Uptime Kuma: Recurse folder permissions Co-authored-by: Max Kowalski <[email protected]> Co-authored-by: owine <[email protected]> * Update minecraft role main.yml (#209) * Update main.yml added `minecraft_dns_proxy: "false"` to DNS section of the role. For anyone that has Proxy enabled, this role will not work at all as is. I'm sure it would be fine if we added it as `minecraft_dns_proxy: "{{ dns.proxied }}"` as long as we update the docs? * Fix boolean Co-authored-by: owine <[email protected]> * make actual adguard commit make actual adguard commit * Adminer t3 update * airdcpp t3 update * airsonic t3 update * test airsonic java options garbage performance - cant change default pass * Alltube - t3 update * alternatrr t3 update * apprise t3 update check web auth * archivebox t3 update no sso * aria2_ng audiobookshelf autobrr t3 updates * beets booksonic bookstack t3 update * booksonic add base url * Revert "booksonic add base url" This reverts commit 772ce83. * calibre caliweb changedetection cherry code_server comixstreamer comixed t3 updates * booksonic dashy deemix delugevpn docspell dozzle duplicati t3 updates * Add missing role tag - duplicati * calibres * E's and F's - T3 updates * G's to J's Traefik 3 code updates Co-authored-by: JigSaw <[email protected]> Co-authored-by: owine <[email protected]> Co-authored-by: CHAIR <[email protected]>
maximuskowalski
added a commit
that referenced
this pull request
Jan 3, 2023
* t3 adguard * feat(uptime-kuma): use PUID/PGID & protect with authelia by default (#211) * fix(uptime-kuma): use PUID/PGID for docker and reset perms * fix(migrator): remove unnecessary code for perms reset * feat(uptime-kuma): protect under authelia by default * feat(uptime-kuma): exclude endpoints for public status pages * Update main.yml minor formatting * Uptime Kuma: Recurse folder permissions Co-authored-by: Max Kowalski <[email protected]> Co-authored-by: owine <[email protected]> * Update minecraft role main.yml (#209) * Update main.yml added `minecraft_dns_proxy: "false"` to DNS section of the role. For anyone that has Proxy enabled, this role will not work at all as is. I'm sure it would be fine if we added it as `minecraft_dns_proxy: "{{ dns.proxied }}"` as long as we update the docs? * Fix boolean Co-authored-by: owine <[email protected]> * make actual adguard commit make actual adguard commit * Adminer t3 update * airdcpp t3 update * airsonic t3 update * test airsonic java options garbage performance - cant change default pass * Alltube - t3 update * alternatrr t3 update * apprise t3 update check web auth * archivebox t3 update no sso * aria2_ng audiobookshelf autobrr t3 updates * beets booksonic bookstack t3 update * booksonic add base url * Revert "booksonic add base url" This reverts commit 772ce83. * calibre caliweb changedetection cherry code_server comixstreamer comixed t3 updates * booksonic dashy deemix delugevpn docspell dozzle duplicati t3 updates * Add missing role tag - duplicati * calibres * E's and F's - T3 updates * G's to J's Traefik 3 code updates * Traefik 3 K's to S's Code updates - yet to test * formatting Co-authored-by: JigSaw <[email protected]> Co-authored-by: owine <[email protected]> Co-authored-by: CHAIR <[email protected]>
maximuskowalski
added a commit
that referenced
this pull request
Jan 3, 2023
* t3 adguard * feat(uptime-kuma): use PUID/PGID & protect with authelia by default (#211) * fix(uptime-kuma): use PUID/PGID for docker and reset perms * fix(migrator): remove unnecessary code for perms reset * feat(uptime-kuma): protect under authelia by default * feat(uptime-kuma): exclude endpoints for public status pages * Update main.yml minor formatting * Uptime Kuma: Recurse folder permissions Co-authored-by: Max Kowalski <[email protected]> Co-authored-by: owine <[email protected]> * Update minecraft role main.yml (#209) * Update main.yml added `minecraft_dns_proxy: "false"` to DNS section of the role. For anyone that has Proxy enabled, this role will not work at all as is. I'm sure it would be fine if we added it as `minecraft_dns_proxy: "{{ dns.proxied }}"` as long as we update the docs? * Fix boolean Co-authored-by: owine <[email protected]> * make actual adguard commit make actual adguard commit * Adminer t3 update * airdcpp t3 update * airsonic t3 update * test airsonic java options garbage performance - cant change default pass * Alltube - t3 update * alternatrr t3 update * apprise t3 update check web auth * archivebox t3 update no sso * aria2_ng audiobookshelf autobrr t3 updates * beets booksonic bookstack t3 update * booksonic add base url * Revert "booksonic add base url" This reverts commit 772ce83. * calibre caliweb changedetection cherry code_server comixstreamer comixed t3 updates * booksonic dashy deemix delugevpn docspell dozzle duplicati t3 updates * Add missing role tag - duplicati * calibres * E's and F's - T3 updates * G's to J's Traefik 3 code updates * Traefik 3 K's to S's Code updates - yet to test * formatting * Traefik 3 T's - Z's code updates untested Co-authored-by: JigSaw <[email protected]> Co-authored-by: owine <[email protected]> Co-authored-by: CHAIR <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added
minecraft_dns_proxy: "false"
to DNS section of the role. For anyone that has Proxy enabled, this role will not work at all as is. I'm sure it would be fine if we added it asminecraft_dns_proxy: "{{ dns.proxied }}"
as long as we update the docs?How Has This Been Tested?