[3006.x] fix #66686: don't fail for InvalidVersion, instead drop the version as-if it was never there #66687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version as-if it was never there
|
This needs some tests and a changelog please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add "support" for InvalidVersion: ignore the version instead of failing completly
What issues does this PR fix or reference?
Fixes #66686
Previous Behavior
Failure when listing all version of a package when there is an InvalidVersion
New Behavior
State pass, but ignore if there is an InvalidVersion, and add a INFO log about this
Merge requirements satisfied?
Commits signed with GPG?
Yes