[master] Make file.manage_file permission, user and group atomic #65657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In this PR, I tweak the internal behavior of
file.manage_file
to improve the file permission and owner consistency while the function is executing. See the linked PR for discussion of why this might be useful to users.In the end, while modifying the code, I found this approach to be the simplest and cleanest; however, I am open to discussions and modifying the approach.
What issues does this PR fix or reference?
Fixes: #65651
Previous Behavior
When the module copied a file, the file temporarily used the
600
perms with the user of the current running process.New Behavior
Currently, the module attempts to modify the basic file attributes as soon as the file is copied to minimize the risk of race conditions.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes