Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] Add coverage for salt/fileclient.py #65401

Open
wants to merge 2 commits into
base: 3006.x
Choose a base branch
from

Conversation

MKLeb
Copy link
Contributor

@MKLeb MKLeb commented Oct 13, 2023

What does this PR do?

See title

What issues does this PR fix or reference?

Fixes: One file for #64739

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@MKLeb MKLeb requested a review from a team as a code owner October 13, 2023 20:51
@MKLeb MKLeb requested review from garethgreenaway and removed request for a team October 13, 2023 20:51
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Add coverage for salt/fileclient.py [3006.x] Add coverage for salt/fileclient.py Oct 13, 2023
@MKLeb MKLeb temporarily deployed to ci October 13, 2023 21:39 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 13, 2023 21:39 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 13, 2023 21:40 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 13, 2023 21:40 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 13, 2023 21:40 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 13, 2023 21:40 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #65401 (905bdfe) into 3006.x (05541f6) will decrease coverage by 0.01%.
Report is 481 commits behind head on 3006.x.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           3006.x   #65401      +/-   ##
==========================================
- Coverage   62.30%   62.28%   -0.01%     
==========================================
  Files        3218     3218              
  Lines      442586   442583       -3     
  Branches    84722    84722              
==========================================
- Hits       275706   275621      -85     
- Misses     151332   151395      +63     
- Partials    15548    15567      +19     
Flag Coverage Δ
almalinux-8 58.83% <ø> (-<0.01%) ⬇️
almalinux-9 58.82% <ø> (+0.01%) ⬆️
amazonlinux-2 58.81% <ø> (-<0.01%) ⬇️
archlinux-lts 58.74% <ø> (+0.01%) ⬆️
centos-7 58.88% <ø> (-<0.01%) ⬇️
centosstream-8 58.86% <ø> (-<0.01%) ⬇️
centosstream-9 58.84% <ø> (-<0.01%) ⬇️
debian-10 58.04% <ø> (+0.01%) ⬆️
debian-11 58.01% <ø> (-<0.01%) ⬇️
debian-11-arm64 58.00% <ø> (+0.01%) ⬆️
debian-12 ?
debian-12-arm64 57.99% <ø> (+0.01%) ⬆️
fedora-37 58.82% <ø> (-<0.01%) ⬇️
fedora-38 58.76% <ø> (+0.01%) ⬆️
opensuse-15 19.27% <ø> (-38.53%) ⬇️
photonos-3 58.47% <ø> (-0.01%) ⬇️
photonos-4 58.45% <ø> (-<0.01%) ⬇️
photonos-4-arm64 58.27% <ø> (+0.01%) ⬆️
salt 46.42% <ø> (-0.01%) ⬇️
tests 89.85% <ø> (-0.02%) ⬇️
ubuntu-20.04 58.03% <ø> (-<0.01%) ⬇️
ubuntu-20.04-arm64 58.03% <ø> (-<0.01%) ⬇️
ubuntu-22.04 16.09% <ø> (-41.94%) ⬇️
ubuntu-22.04-arm64 58.02% <ø> (-<0.01%) ⬇️
windows-2016 46.71% <ø> (+0.12%) ⬆️
windows-2019 53.23% <ø> (-<0.01%) ⬇️
windows-2022 53.16% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
salt/fileclient.py 72.61% <ø> (+3.34%) ⬆️

... and 42 files with indirect coverage changes

@MKLeb MKLeb temporarily deployed to ci October 14, 2023 02:26 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 14, 2023 02:27 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 14, 2023 02:27 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 14, 2023 02:28 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 14, 2023 02:30 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 14, 2023 02:31 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 14, 2023 10:16 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 14, 2023 10:17 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 14, 2023 10:19 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 14, 2023 10:21 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 14, 2023 10:23 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 14, 2023 10:28 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 16, 2023 17:33 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 16, 2023 17:33 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 16, 2023 17:33 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 16, 2023 17:33 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 16, 2023 17:33 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci October 16, 2023 17:33 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants