Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix timeout for salt-api #62188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

notnooblord
Copy link

@notnooblord notnooblord commented Jun 17, 2022

What does this PR do?

Move format_call under try block to protect from DDoS from bad requests without password or username fields.

What issues does this PR fix or reference?

Fixes: #62187

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@notnooblord notnooblord requested a review from a team as a code owner June 17, 2022 11:00
@notnooblord notnooblord requested review from ScriptAutomate and removed request for a team June 17, 2022 11:00
@welcome
Copy link

welcome bot commented Jun 17, 2022

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@ScriptAutomate ScriptAutomate requested review from a team and garethgreenaway and removed request for ScriptAutomate and a team September 15, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] salt-api server dies on bad /login request
2 participants