-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Document vCenter ESXi proxy options. Cleanup headers of all VMware proxies. Fixes #61987 #61990
base: master
Are you sure you want to change the base?
[DOCS] Document vCenter ESXi proxy options. Cleanup headers of all VMware proxies. Fixes #61987 #61990
Conversation
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)Check Known Missing Docstrings...........................................Failed - hook id: invoke - duration: 1.05s - exit code: 1 Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ggiesen , sorry that it's taken me awhile to look at this. I've approved this PR. Just be aware we'll need to rebase this because I've added some warnings to this module that users should use the VMware Salt extension instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I had to revoke my approval because it looks like we're getting a missing docstring warning on this?
@ggiesen, what's your take on the missing docstring error flagged by the GitHub actions bot?
@ggiesen , any updates on this PR? |
611e35f
to
a89806e
Compare
Pre-commit failing. |
What does this PR do?
Documents vCenter options for ESXi proxy. Spelling, formatting and consistency cleanups of all VMware proxy docs.
What issues does this PR fix or reference?
Fixes: #61987
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.