fix(python): use python3 postgres on cent7/8 #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vutny
requested changes
Dec 1, 2020
|
Will do! |
2ac27a1
to
d64f6ad
Compare
vutny
requested changes
Dec 3, 2020
| @@ -62,6 +62,10 @@ RedHat: | |||
| gpgkey: 'https://download.postgresql.org/pub/repos/yum/RPM-GPG-KEY-PGDG-{{ release }}' | |||
| baseurl: 'https://download.postgresql.org/pub/repos/yum/{{ repo.version }}/redhat/rhel-$releasever-$basearch' | |||
|
|
|||
| {%- if 'osfinger' in grains and grains.osfinger in ('CentOS Linux-7', 'CentOS Linux-8') %} | |||
| pkg_python: python3-psycopg2 | |||
There was a problem hiding this comment.
And set the default to python3-psycopg2 as it was in you initial implementation, since it would cover modern Ubuntus too.
Suggested change
| pkg_python: python3-psycopg2 | |
| pkg_python: python-psycopg2 |
There was a problem hiding this comment.
It is python3-psycopg2 for Centos 7. Maybe {%- if grains.get('osmajorrelease') >= 7) %} should wrap this?
There was a problem hiding this comment.
Oh, yeah. It would be even better.
|
thanks @vutny let me know if this is okay. |
|
🎉 This PR is included in version 0.41.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
Describe the changes you're proposing
The python driver is typically called
python3-psycopg2these days (Ubuntu 18, Centos8).Centos7 is
python-pyscopg2but this repo has noosfingermap.yaml.Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context