allow to add bin_dir to path #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierbertoli
requested changes
Oct 10, 2018
There was a problem hiding this comment.
@gilou would you add an entry in pillar.example to document/show this variable usage?
Also, and this is just a suggestion, perhaps it's better to rename the var from add_path to add_profile? It's what it does and, perhaps in the future, other options might be added there, which will render the name add_path incorrect?
|
I agree for the name, maybe it can be extended, and I wasn't thrilled by my choice. Is the explanation I added clear enough? |
|
Merged. Thanks, @gilou! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installed from repo, add a add_path option to include bin_dir in $PATH through a file in /etc/profile.d
Disabled by default, as it wasn't added before.