Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npm warnings (#28) #96

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Fix npm warnings (#28) #96

merged 1 commit into from
Oct 18, 2017

Conversation

maxpou
Copy link
Contributor

@maxpou maxpou commented Oct 17, 2017

In #28 resolution (see #29) I forget to commit the NPM warn part

Case

IS IT A: ENHANCEMENT

Issue

On npm install, I found several issues:

Proposal:

  • update the package.json by adding the 2 missing fields.

Info

  • Operating System: OSX
  • Node-Version: 5.4.1

Reproduce

rm -rf node_modules
npm install

@pubkey
Copy link
Collaborator

pubkey commented Oct 18, 2017

Thx, merged!

@pubkey pubkey merged commit 938fba0 into salomonelli:master Oct 18, 2017
@maxpou maxpou deleted the package-json branch October 25, 2017 09:12
mattaschmann pushed a commit to mattaschmann/best-resume-ever that referenced this pull request Mar 9, 2020
@pubkey
Merge pull request salomonelli#96 from maxpou/package-json
145de22 
Fix npm warnings (salomonelli#28)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxpou @pubkey