test: improve tests for unhandled rejections #4453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Aug 9, 2024
| window.onerror = originalOnError; | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
This is 99% copypasta from LightningElement.errorCallback/index.spec.js
wjhsf
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The current tests for #4451 and #3827 are somewhat janky – they occasionally log to the DevTools console which is very distracting.
Luckily I already had some code to capture unhandled rejections/errors, so I just extracted this into a general-purpose utility so that we can improve this test.
This is spun off from #4452 to avoid bloating that PR.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?