Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): add missing and remove unused deps #4421

Merged
merged 1 commit into from
Jul 29, 2024
Merged

chore(deps): add missing and remove unused deps #4421

merged 1 commit into from
Jul 29, 2024

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Jul 29, 2024

Details

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.
  • 💔 Yes, it does introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.
  • 🔬 Yes, it does include an observable change.

GUS work item

@wjhsf wjhsf requested a review from a team as a code owner July 29, 2024 20:23
@@ -43,6 +43,8 @@
},
"dependencies": {
"@babel/helper-module-imports": "7.24.7",
"@babel/traverse": "^7.25.1",
"@babel/types": "^7.25.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lwc/babel-plugin-component only uses these packages for the typescript types, but I guess we need it as a dep rather than a devDep for the benefit of TS consumers, correct?

@nolanlawson
Copy link
Collaborator

/nucleus test

Copy link
Contributor

Well that's strange! A workflow could not be found for this PR. Please try running the /nucleus start command to start the workflow.

@nolanlawson
Copy link
Collaborator

/nucleus start

@wjhsf wjhsf merged commit 4ba6b1e into master Jul 29, 2024
11 checks passed
@wjhsf wjhsf deleted the wjh/depcheck branch July 29, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants