chore(eslint): ignore .gitignored files #4383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
covered by globals.jasmine
wjhsf
commented
Jul 15, 2024
| @@ -314,7 +311,6 @@ export default [ | |||
| lwcRuntimeFlags: true, | |||
| process: true, | |||
| LWC: true, | |||
| spyOnAllFunctions: true, | |||
There was a problem hiding this comment.
This key is covered by ...globals.jasmine, we don't need to specify it ourselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
I came across the @typescript-eslint/explicit-module-boundary-types rule, and I wanted to see how we fare against it. We got a lot of errors, but I noticed a bunch of them were coming from the
.rollup.cachedirectory. We don't care about that directory, or anything that's.gitignored, so I added a plugin so we don't have to maintain duplicate lists. (I did not add the new rule because it turns out we still get a lot of errors, even when we ignore everything we don't care about.)I also added the
tseslint.config()wrapper - it doesn't modify the provided config, but it provides type checking, which makes IDE autocomplete more useful!Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item